Fix broken css/js files on individual shaare pages

[immanuelfodor]

This PR fixes individual shaare pages (e.g., /shaare/o3Fv-w) as the relative path is no longer working:

[ilesinge]

Thank you @immanuelfodor !

[ilesinge]

Hey in fact it doesn't work for me in my production environment, the links end up being: //plugins/related/related.css and //plugins/related/related.js, which are translated by the browser as:
https://plugins/...
In order to remove the double slash, I end up having to modify the code:
$data['css_files'][] = ($data['BASE_PATH'] ?? '') . PluginManager::$PLUGINS_PATH . '/related/related.css'

Since it's a strategy used in other plugins, @immanuelfodor @ArthurHoaro do you know if my modification is correct or if it's my production environment that is somewhat broken ?

[immanuelfodor]

Hmm, maybe you have something in your config.json.php that modifies the defaults? I think that is why your base path has became / instead of empty string (by default). Mine looks like:

<?php /*
{
    "resource": {
        "data_dir": "data",
        "config": "data\/config.php",
        "datastore": "data\/datastore.php",
        "ban_file": "data\/ipbans.php",
        "updates": "data\/updates.txt",
        "log": "data\/log.txt",
        "update_check": "data\/lastupdatecheck.txt",
        "history": "data\/history.php",
        "raintpl_tpl": "tpl\/",
        "raintpl_tmp": "tmp\/",
        "thumbnails_cache": "cache",
        "page_cache": "pagecache",
        "theme": "material"
    },
...
    "general": {
        "header_link": "\/",
...
    "plugins": {
        "_BASE_PATH_": "",
...

The last variable seems extremely suspicious to me :)

[ArthurHoaro]

I'm sorry, I actually made a mistake in the other thread. The base path is added in the default template, so it's now added twice.

{loop="$plugins_footer.js_files"}
	<script src="{$base_path}/{$value}#"></script>
{/loop}

The last variable seems extremely suspicious to me :)

It looks like a bug, and I have the same thing in my local dev environment. Can you open an issue?

[immanuelfodor]

Of course, the Material theme indeed just outputs the value:

• https://github.com/kalvn/Shaarli-Material/blob/support-v012/material/includes.html#L48
• https://github.com/kalvn/Shaarli-Material/blob/support-v012/material/page.footer.html#L30

Opened a new issue at shaarli/Shaarli#1548