Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor compatibility issues with Shaarli v0.12.0-beta #5

Closed
ArthurHoaro opened this issue Aug 27, 2020 · 2 comments
Closed

Minor compatibility issues with Shaarli v0.12.0-beta #5

ArthurHoaro opened this issue Aug 27, 2020 · 2 comments

Comments

@ArthurHoaro
Copy link
Contributor

Hi, thanks for the quick upgrade!

I just updated my instance, and I notice 2 minors issues:

  • related permalinks use the legacy route (?hash instead of {$base_path}/shaare/hash), so there is an unnecessary redirection
  • icon no longer work in permalink view, you probably need to use base_path template variable.
ilesinge added a commit that referenced this issue Aug 27, 2020
Fix issue #5 incorrect icon path in permalink view
@ilesinge
Copy link
Owner

  • related permalinks use the legacy route: Yes, noticed. I prefer to keep this as-is to support older Shaarli versions.
  • icon no longer work in permalink view: Thanks ! It is now fixed.

@ArthurHoaro
Copy link
Contributor Author

Great thanks! And you're right, that's a good way to maintain multiple Shaarli versions within a single release. I usually just release a new version of the plugin, compatible with the latest version of Shaarli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants