Retrieve Alias Path #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2018 16:24
This will retrieve an alias's path from the moduleAliases object
|
I would love to see this merged. I used it to debug and it worked great. |
|
I would love to see this merged too. Any update on this? |
ilearnio
requested changes
Feb 10, 2019
ilearnio
reviewed
Feb 10, 2019
test/specs.js
Outdated
| }) | ||
|
|
||
| it('should throw when alias is not a string', function () { | ||
| var expected = '[123]: is not of type string'; |
There was a problem hiding this comment.
Suggested change
| var expected = '[123]: is not of type string'; | |
| var expected = '"123" is not of type string' |
|
On a note I think the travis linting is going to cause more issues than good. As we are running different IDE styleguides. It may be beneficial for you to run your proffered settings over the project |
|
@LukeInTheCloud, The time has passed and nothing changed. I think in that case is easier create another module called reverse-module-alias and make reverse alias/realpath conversions. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Added a method that will take a alias as a string, validate that it exists in the moduleAliase's object. and that it is of type string. This will then return the relevant path for that alias.
Reason
We came across the need in our express/typescript environment to create dynamic imports as well as fs read processes. These file paths are not imported and change depending on the environment. This will you to use the registered aliases outside of a import or require.