-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved startup script to own module #2547
Conversation
bc478d6
to
19283fa
Compare
Should we create an issue in the |
Codecov Report
@@ Coverage Diff @@
## main #2547 +/- ##
==========================================
+ Coverage 51.56% 51.57% +0.01%
==========================================
Files 514 514
Lines 60141 60141
Branches 9169 9169
==========================================
+ Hits 31009 31019 +10
+ Misses 27522 27514 -8
+ Partials 1610 1608 -2
Continue to review full report at Codecov.
|
I think this might have been my bad... |
19283fa
to
c571477
Compare
okay this one is really annoying. I tried different variants, also following the conda-build tests that test that it actually should be working, but I never got an exe file on windows for the script when supplied as |
Do we even need an entrypoint for non-packaged ilastik variants? I think devs and people who want to use conda-based ilastik should be fine with |
I'm thinking not of devs but people who install ilastik using conda. They should be able to |
turns out this might be some conda build issue (tracking it here: conda/conda-build#4385). So in order to keep things noarch, an explicit entrypoint is (currently) needed. cc: @emilmelnikov |
c571477
to
4c662bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename the module to ilastik.main
, or at least ilastik.startup
?
in order to include this in the package and be able to use it as a clean entrypoint.
4c662bf
to
5c7dcf5
Compare
5c7dcf5
to
8312538
Compare
I forgot to include the startup script in the conda package for a reason ;)
I did try to use the setup.py scripts directive, but this will not work reliably as an entrypoint in conda.
note: this entrypoint has to run before any import of an ilastik module.