forked from Qiskit/qiskit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix VF2Layout and VF2PostLayout handling of instructions without error (
Qiskit#8978) * Fix VF2Layout and VF2PostLayout handling of instructions without error This commit fixes an issue in the VF2Layout and VF2PostLayout pass where the passes would potentially error in cases when a target was specified and there were instructions present without any error rates defined. In such cases the instructions should be treated as ideal (having no error) and the passes shouldn't fail. In cases where there are no error rates in the target for VF2Layout the first perfect match should be used, and for VF2PostLayout it should effectively be a no-op and not select a new layout. Fixes Qiskit#8970 * Add missing comma to comment * Exit early if score is 0 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
- Loading branch information
1 parent
de8e4dd
commit 6580d96
Showing
6 changed files
with
132 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
releasenotes/notes/fix-vf2-layout-no-noise-22261601684710c3.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
fixes: | ||
- | | ||
Fixed an issue with the :class:`~.VF2Layout` pass where it would error | ||
when running with a :class:`~.Target` that had instructions that were | ||
missing error rates. This has been corrected so in such cases the | ||
lack of an error rate will be treated as an ideal implementation and | ||
if no error rates are present it will just select the first matching | ||
layout. | ||
Fixed `#8970 <https://github.com/Qiskit/qiskit-terra/issues/8970>`__ | ||
- | | ||
Fixed an issue with the :class:`~.VF2PostLayout` pass where it would | ||
error when running with a :class:~.Target` that had instructions that | ||
were missing. In such cases the lack of an error rate will be treated as | ||
an ideal implementation of the operation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters