Merge pull request #409 from ikemo3/fix/javascript-error

fix: remove 'javascript:void(0)'
ikemo3 · Aug 15, 2022 · ef8762c · ef8762c
2 parents f960787 + edcdc5a
commit ef8762c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/apps/common.ts b/apps/common.ts
@@ -100,7 +100,8 @@ export const $ = {
     anchor(text?: string): HTMLAnchorElement {
         const anchor = document.createElement("a");
         // eslint-disable-next-line no-script-url
-        anchor.setAttribute("href", "javascript:void(0)"); // change link color.
+        anchor.removeAttribute("href");
+        anchor.classList.add("gsb-anchor");
 
         if (text !== undefined) {
             anchor.textContent = text;

diff --git a/apps/styles/google.css b/apps/styles/google.css
@@ -189,3 +189,7 @@ div[role="listitem"] {
     margin-left: 0 !important;
     white-space: normal !important;
 }
+
+.gsb-anchor {
+    cursor: pointer;
+}