Ikasan 2364 backfill h2 backup changes discovered while testing #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | datasource.username | The H2 database username | | | ||
| | datasource.password | The H2 database password | | | ||
| | default.ikasan.h2.backup.num.to.retain | The number of backups to retain | 2 | | ||
| | default.ikasan.h2.backup.cron.expression | The Quartz cron schedule on which the backups are taken | 37 0/5 * * * ? | |
There was a problem hiding this comment.
Seems the default ikasan backup is at 17 sec not 37
| @@ -33,12 +40,18 @@ public class IkasanBackupAutoConfiguration { | |||
| @Value("${default.ikasan.h2.backup.num.to.retain:2}") | |||
| private int defaultIkasanDatabaseBackupNumToRetain; | |||
|
|
|||
| @Value("${default.ikasan.h2.backup.cron.expression:17 0/1 * * * ?}") | |||
| @Value("${default.ikasan.h2.backup.cron.expression:17 0/5 * * * ?}") | |||
There was a problem hiding this comment.
Double check documentation
| @Value("${h2.db.port}") | ||
| private int eaiH2PortNumber; | ||
|
|
||
| @Value("${eai.h2.port.number.step:1000}") |
There was a problem hiding this comment.
do we think 1000 step is good, or should be different for Ikasan
There was a problem hiding this comment.
It is configurable so in my opinion yes.
andrzej-majewski
previously approved these changes
May 2, 2024
andrzej-majewski
approved these changes
May 6, 2024
andrzej-majewski
deleted the
IKASAN-2364-backfill-h2-backup-changes-discovered-while-testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.