Remove action handler which was conflicting with tap handling #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A lot of the diffs here are just from prettier running and auto-formatting (I'm guessing recent changes which didn't have prettier run on them) |
ikaruswill
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The card level action handler from the boilerplate card seems to be messing with tap events. It's not clear to me what this action handler is supposed to do, and unfortunately the boilerplate card and custome helpers have very little documentation.
Removing the handler seems to return the behavior to what I'd expect to happen - both tap/touch and mouse click events fire the "click" event on individual elements, and the events bubble up the tree instead of being handled by the parent first.
Fixes #107