-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAPM publishing #31
WAPM publishing #31
Conversation
Actually, can I ask you to wait with merging this for a bit? It might be necessary to downgrade rust to 1.56 for the release build because of this bug. |
OK, please notify me after the bug is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the bug is fixed, I will test these workflows.
@@ -38,31 +39,33 @@ jobs: | |||
echo "PROJECT_VERSION=${GITHUB_REF#refs/tags/v}" >> "$GITHUB_ENV" | |||
echo "Version: ${{ env.PROJECT_VERSION }}" | |||
|
|||
- name: Check git tag against toml values | |||
if: ${{ matrix.job.os != 'windows-2019' }} # windows too weird |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are identical among jobs, so just checking on one job, ubuntu-20.04
for example, is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what I thought at first, too, but tell me: Won't the publish step for the other os
still run, creating a release with some missing files?
omekasy/.github/workflows/release.yml
Lines 89 to 95 in a36cd66
- name: Publish | |
if: ${{ contains(github.ref, '/tags/') }} | |
uses: softprops/action-gh-release@v1 | |
with: | |
files: ${{ env.PKG_PATH }} | |
env: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
I give up. Instead of that bug above getting fixed, webassembly.sh is getting more and more broken. You could of course publish to wapm.io for other reasons, but I'm not quite sure what those would be. (Unrelated: I might package this for nixpkgs, though. [Edit:] Easy.) |
Implements #29.
I've tested this on some other repository, but I obviously can't test it on yours. So there might be some quirks.
For the login token, you'll have to:
And then register that as a new repository secret on this github repo.