Fix type-based code completion for some LSPs #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
picobox.Stack()
is missing few key type annotations that breaks autocompletion for some LSP servers. For instance, in the following code example:there are two broken autocompletion points:
.put()
is not completed for thebox
variable.value
is not completed for the struct type returned bypack()
This patch fixes these scenarios by (1) annotating that
picobox.push()
returns a context manager, and (2) avoiding using too-much-dynamic expressions inpicobox.pass_()
which return type cannot be easily inferred.