Add more CI test platforms #35
Conversation
|
Hey @nyurik, Thank you for the patch and sorry for being unresponsive that long. The patch makes sense to me and I'd be happy to accept it. Let us first figure out how to proceed with broken tests now. See #38 (comment) for details. |
|
Hey @nyurik, May I ask you to rebase your change? I believe the broken test is fixed in the master branch. |
.github/workflows/ci.yml
Outdated
| @@ -18,13 +18,18 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: | |||
| - ubuntu-latest | |||
There was a problem hiding this comment.
*-latest runners are tested in the parametrized job. So maybe we can save some CPU cycles by not running them here.
Ensure this action would pass on all available GitHub runners
.github/workflows/ci.yml
Outdated
| - macos-13 | ||
| - ubuntu-22.04 | ||
| - ubuntu-24.04 | ||
| - macos-11 |
There was a problem hiding this comment.
I don't think macos-11 exist, and this is why the check could not finish. It looks like the only missing platform is ubuntu-24.04, according to the GitHub docs:
So I think this patch could be a 1 line change, after all. 🤔
There was a problem hiding this comment.
ah, they removed 11 i guess. will fix
Ensure this action would pass on all available GitHub runners