Skip to content

Commit

Permalink
Revert "Revert "Pyarrow Segfault Regression Test (ray-project#7568)" (r…
Browse files Browse the repository at this point in the history
…ay-project#7805)"

This reverts commit eb61036.
  • Loading branch information
ijrsvt committed Mar 30, 2020
1 parent eb61036 commit 263997e
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 0 deletions.
8 changes: 8 additions & 0 deletions python/ray/tests/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -407,3 +407,11 @@ py_test(
tags = ["exclusive"],
deps = ["//:ray_lib"],
)

py_test(
name = "test_symbol_collisions",
size = "small",
srcs = ["test_symbol_collisions.py"],
tags = ["exclusive"],
deps = ["//:ray_lib"],
)
29 changes: 29 additions & 0 deletions python/ray/tests/test_symbol_collisions.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
"""
This script ensures that various libraries do not conflict with ray by
trying to import both libraries in both orders.
A specific example is that importing ray after pyarrow causes a Segfault.
"""
import subprocess

TESTED_LIBRARIES = ["pyarrow"]


def test_imports():
def try_imports(library1, library2):
return_info = subprocess.run([
"python", "-c", "import {}; import {}".format(library1, library2)
])
if return_info.returncode != 0:
return "Importing {} before {} caused an error".format(
library1, library2)
return ""

for library in TESTED_LIBRARIES:
assert try_imports("ray", library) == ""
assert try_imports(library, "ray") == ""


if __name__ == "__main__":
import sys
import pytest
sys.exit(pytest.main(["-v", __file__]))

0 comments on commit 263997e

Please sign in to comment.