Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to save this #61

Closed
Vibex opened this issue May 21, 2014 · 3 comments
Closed

Try to save this #61

Vibex opened this issue May 21, 2014 · 3 comments
Labels

Comments

@Vibex
Copy link

Vibex commented May 21, 2014

{backcolor:"#232427"},
[{rx:2.75,ry:6.75,x:2,c:"#2d3238",t:"#525554",p:"DSA",a:7,f:8},"U"],
[{y:-6.5,x:-1.75},"W",{x:1},"P","V"],
[{y:-0.75,x:-2.75},"J"],
[{y:-0.5,x:-0.75},"S"],
[{y:-0.75,x:-1.75},"I",{x:1},"T","L"],
[{y:-0.75,x:-2.75},"A"],
[{y:-0.5,x:-0.75},"C"],
[{y:-0.75,x:-1.75},"X",{x:1},"G",{c:"#2b2c2e",t:"#857eb1",f:4,w:1.5},"Navigate"],
[{y:-0.75,x:-2.75,c:"#2d3238",t:"#525554",f:8},"Z"],
[{y:-0.25,x:0.75,c:"#2b2c2e",t:"#006d59",f:4,w:2,w2:1},"Space"],
[{x:1.75,t:"#2e6ea6"},"Alt"],
[{rx:10,ry:0,x:-1,c:"#2d3238",t:"#525554",f:8},"M"],
[{y:-0.75,x:-3},"B","Y",{x:1},"D"],
[{y:-0.75,x:1},"K"],
[{y:-0.5,x:-1},"E"],
[{y:-0.75,x:-3},"R","N",{x:1},"O"],
[{y:-0.75,x:1,f:4},"Pnc"],
[{y:-0.5,x:-1,f:8},"H"],
[{y:-0.75,x:-3.5,c:"#2b2c2e",t:"#d290b4",f:4,w:1.5},"Enter",{c:"#2d3238",t:"#525554",f:8},"F",{x:1},"Q"],
[{y:-0.75,x:1,f:4},"Shift"],
[{y:-0.25,x:-3.5,c:"#2b2c2e",t:"#ff6d1a",w:2},"Backspace"],
[{x:-3.5,t:"#b81b24"},"CTRL"]

@ijprest ijprest added the bug label Jul 2, 2015
@iandoug
Copy link
Contributor

iandoug commented Jul 2, 2015

@ijprest: I have a fixed version of this.

ijprest pushed a commit that referenced this issue Jul 3, 2015
-- If the first row in your layout was rotated, the x & y coordinates
didn't get output correctly.
-- The serializer didn't take into account that *both* x & y are updated
when *either* rx & ry are specified in the output; as a result, it would
mis-calculate the correct x & y coordinates for some rotated keys.
-- Fixes #57 and #61
@ijprest
Copy link
Owner

ijprest commented Jul 3, 2015

@iandoug: I didn't see any serialization changes in your fork... did I miss something? Regardless, I tracked down the serialization error and fixed it.

@ijprest ijprest closed this as completed Jul 3, 2015
@iandoug
Copy link
Contributor

iandoug commented Jul 4, 2015

Jordi was working on that code, so I didn't want to mess with it. Instead I fixed the layout data directly so that it loaded correctly. Did you get the email I sent you to the address in your commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants