Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed passing @tagName for dynamic tag #46

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Allowed passing @tagName for dynamic tag #46

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
662c00b
Disallowed accessibility audit in development (to avoid runloop error)
ijlee2 Jul 3, 2020
112ee41
Allowed dynamic tag, but restricted it to be immutable
ijlee2 Jul 3, 2020
22e1cdf
Applied @tagName to the demo app
ijlee2 Jul 9, 2020
13cb771
Added rendering tests for @tagName
ijlee2 Jul 9, 2020
a08b2b7
Updated README
ijlee2 Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/dummy/config/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ module.exports = function(environment) {
}
};

ENV['ember-a11y-testing'] = {
componentOptions: {
turnAuditOff: true
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I turned off ember-a11y-testing in development because I ran into an error while testing window resize:

element-resize-detector.js:165 Uncaught Axe is already running. Use `await axe.run()` to wait for the previous run to finish before starting a new run.

}
}

if (environment === 'development') {
// ENV.APP.LOG_RESOLVER = true;
// ENV.APP.LOG_ACTIVE_GENERATION = true;
Expand Down