Renamed the two types of options #9
Merged
+355
−355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ember-codemod-v1-to-v2
's code stemmed fromember-codemod-pod-to-octane
, which had one (1) type of options. This project, on the other hand, has two:The problem is, in almost all files (except
src/migration/ember-addon/index.js
), I used the nameoptions
to refer to either type of options. Without TypeScript in place, using the same name will lead to confusion and bugs.Solution
I reserved the name
options
for the "actual" options. That is,options
, from now on, means the options that the migration steps receive as input. Thisoptions
has the "complete" set of options that is required for the codemod to work.The other type of options—the one that an end-developer provides—is now called
codemodOptions
.At a later point, I will update
ember-codemod-pod-to-octane
to follow the same naming convention.