-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated blueprints #66
Merged
+156
−154
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feature: Downstreamed changes from @embroider/addon-blueprint@2.5.0 a…
…nd ember-cli@5.2.0
commit 6c4caa292e80ce00650f7984438a9874e0dc2126
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,9 +19,11 @@ function updateCompilerOptions( | |
|
||
if (packages.addon.hasGlint) { | ||
compilerOptions.set('allowImportingTsExtensions', true); | ||
compilerOptions.set('allowJs', true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Downstreamed from embroider-build/addon-blueprint#162 |
||
compilerOptions.set('declarationDir', 'declarations'); | ||
} else { | ||
compilerOptions.set('allowImportingTsExtensions', true); | ||
compilerOptions.set('allowJs', true); | ||
compilerOptions.set('declaration', true); | ||
compilerOptions.set('declarationDir', 'declarations'); | ||
compilerOptions.set('emitDeclarationOnly', true); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,8 @@ function updateCompilerOptions( | |
tsConfigJson['compilerOptions'] = convertToObject(compilerOptions); | ||
} | ||
|
||
function updateInclude(tsConfigJson: TsConfigJson): void { | ||
tsConfigJson['include'] = ['app/**/*', 'tests/**/*', 'types/**/*']; | ||
function removeInclude(tsConfigJson: TsConfigJson) { | ||
delete tsConfigJson['include']; | ||
Comment on lines
+26
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Downstreamed from ember-cli/ember-cli#10283 |
||
} | ||
|
||
export function updateTestAppTsConfigJson(options: Options): void { | ||
|
@@ -39,7 +39,7 @@ export function updateTestAppTsConfigJson(options: Options): void { | |
const tsConfigJson = JSON.parse(sanitizeJson(oldFile)); | ||
|
||
updateCompilerOptions(tsConfigJson, options); | ||
updateInclude(tsConfigJson); | ||
removeInclude(tsConfigJson); | ||
|
||
const newFile = JSON.stringify(tsConfigJson, null, 2) + '\n'; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downstreamed from ember-cli/ember-cli#10283