Updated blueprints to match @embroider/[email protected] #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
added
enhance: code
ijlee2
commented
Aug 12, 2023
| @@ -23,7 +23,7 @@ | |||
| "concurrently": "<%= context.projectRoot.devDependencies['concurrently'] %>" | |||
| } | |||
| }<% } else if (options.packageManager.isPnpm) { %>{ | |||
| "name": "<%= options.packages.addon.name %>", | |||
| "name": "workspace-root", | |||
There was a problem hiding this comment.
By giving the workspace root a name, we may easily distinguish where dependencies come from, when we run the outdated command, e.g. pnpm outdated -r.
ijlee2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I downstreamed changes from
@embroider/[email protected],2.2.1, and2.3.0.Notes
@embroider/[email protected]adds support for*.{gjs,gts}files. To keep the scope small, I did not include this change.@embroider/[email protected]may introduce breaking changes to the codemod. That is, there may be files that the codemod needs to update, in order for the end-developer's project to run with@embroider/[email protected]. I didn't investigate yet if such files exist.To account for possible bugs, I'll make the minor release
0.10.0instead of a patch release0.9.2.