Patched #54

.eslintrc.cjs

@@ -35,7 +35,6 @@ module.exports = {
       extends: ['plugin:@typescript-eslint/recommended-type-checked'],
       rules: {
         '@typescript-eslint/array-type': 'error',
-        '@typescript-eslint/no-non-null-assertion': 'off',
         '@typescript-eslint/no-unsafe-argument': 'off',
         '@typescript-eslint/no-unsafe-assignment': 'off',
       },

.github/ISSUE_TEMPLATE/report-bug.md

@@ -14,38 +14,23 @@ Before you make a new issue, please search for similar issues. It's possible tha
 
 ## Describe the bug 🐞
 
-A clear and concise description of what the bug is.
+A clear and concise description of the bug.
 
 
 ## Expected behavior 🤔
 
-A clear and concise description of what you expected to happen.
+A clear and concise description of what you expected to see.
 
 
 ## Minimal reproduction 🔬
 
-Describe steps to reproduce the behavior:
+Describe steps to reproduce the issue.
 
-1. Go to '...'
-2. Click on '...'
-3. Scroll down to '...'
-4. See error
+1. ...
+1. ...
+1. ...
 
-If possible, please, share a link with a minimal reproduction.
-
-<!--
-Create a minimal reproduction using one of the following:
-- Ember Twiddle: https://ember-twiddle.com/
-- Create a GitHub repository: https://guides.emberjs.com/release/getting-started/quick-start/
--->
-
-
-## Environment 🌍
-
-- Ember: -
-- Node.js/npm: -
-- OS: -
-- Browser: -
+If possible, please share a repo with the minimum files to reproduce the issue.
 
 
 ## Additional context ➕

.prettierrc.cjs

@@ -7,7 +7,6 @@ module.exports = {
       options: {
         printWidth: 80,
         singleQuote: true,
-        trailingComma: 'all',
       },
     },
   ],

README.md

@@ -53,7 +53,7 @@ In most cases, I recommend running the codemod without any arguments (i.e. allow
 By default, the package name decides where the addon package lives. Pass `--addon-location` to override the logic. This may be useful if you have a workspace with many addons.
 
 ```sh
-npx ember-codemod-v1-to-v2 --addon-location="packages/ui/buttons"
+npx ember-codemod-v1-to-v2 --addon-location packages/ui/buttons
 ```
 
 </details>
@@ -64,7 +64,7 @@ npx ember-codemod-v1-to-v2 --addon-location="packages/ui/buttons"
 Pass `--root` to run the codemod on a project somewhere else (i.e. not in the current directory).
 
 ```sh
-npx ember-codemod-v1-to-v2 --root=<path/to/your/project>
+npx ember-codemod-v1-to-v2 --root <path/to/your/project>
 ```
 
 </details>
@@ -75,7 +75,7 @@ npx ember-codemod-v1-to-v2 --root=<path/to/your/project>
 By default, the test-app package lives in the folder `test-app`. Pass `--test-app-location` to override the logic.
 
 ```sh
-npx ember-codemod-v1-to-v2 --test-app-location="docs-app"
+npx ember-codemod-v1-to-v2 --test-app-location docs-app
 ```
 
 </details>
@@ -86,7 +86,7 @@ npx ember-codemod-v1-to-v2 --test-app-location="docs-app"
 By default, the test-app package is named `test-app`. Pass `--test-app-name` to override the logic. This may be useful if you have a workspace with many addons.
 
 ```sh
-npx ember-codemod-v1-to-v2 --test-app-name="test-app-for-ui-buttons"
+npx ember-codemod-v1-to-v2 --test-app-name test-app-for-ui-buttons
 ```
 
 </details>
@@ -105,7 +105,7 @@ cd <path/to/cloned/repo>
 pnpm build
 
 # Run codemod
-./dist/bin/ember-codemod-v1-to-v2.js --root=<path/to/your/project>
+./dist/bin/ember-codemod-v1-to-v2.js --root <path/to/your/project>
 ```
 
 You can also look at another codemod called [`ember-addon-migrator`](https://github.com/NullVoxPopuli/ember-addon-migrator).

codemod-test-fixture.sh

@@ -15,15 +15,15 @@
 #
 #---------
 
-# Read the named arguments
-while getopts ":a:" flag
+# Get named arguments for the binary
+while getopts ":N:" flag
 do
   case $flag in
-    a) ARGUMENTS=$OPTARG;;
+    N) NAMED_ARGUMENTS=$OPTARG;;
   esac
 done
 
-# Read the positional arguments
+# Get fixture name
 FIXTURE=${@:$OPTIND:1}
 
 if [ ! $FIXTURE ]
@@ -39,6 +39,6 @@ fi
 rm -r "tests/fixtures/$FIXTURE/output"
 cp -r "tests/fixtures/$FIXTURE/input" "tests/fixtures/$FIXTURE/output"
 
-./dist/bin/ember-codemod-v1-to-v2.js $ARGUMENTS --root="tests/fixtures/$FIXTURE/output"
+./dist/bin/ember-codemod-v1-to-v2.js $NAMED_ARGUMENTS --root="tests/fixtures/$FIXTURE/output"
 
 echo "SUCCESS: Updated the output of $FIXTURE.\n"

codemod-test-fixtures.sh

@@ -16,7 +16,7 @@
 pnpm build
 
 ./codemod-test-fixture.sh \
-  -a "--addon-location packages/ember-container-query --test-app-location demo-app --test-app-name demo-app-for-ember-container-query" \
+  -N "--addon-location packages/ember-container-query --test-app-location demo-app --test-app-name demo-app-for-ember-container-query" \
   ember-container-query-customizations
 
 ./codemod-test-fixture.sh \
@@ -32,7 +32,7 @@ pnpm build
   ember-container-query-typescript
 
 ./codemod-test-fixture.sh \
-  -a "--addon-location packages/new-v1-addon --test-app-location demo-app --test-app-name demo-app-for-new-v1-addon" \
+  -N "--addon-location packages/new-v1-addon --test-app-location demo-app --test-app-name demo-app-for-new-v1-addon" \
   new-v1-addon-customizations
 
 ./codemod-test-fixture.sh \

package.json

@@ -69,16 +69,15 @@
     "typescript": "^5.1.6"
   },
   "engines": {
-    "node": ">= 16"
+    "node": "16.* || >= 18"
   },
   "changelog": {
     "labels": {
       "breaking": "Breaking Change",
       "bug": "Bug Fix",
       "enhance: code": "Enhancement",
       "enhance: dependency": "Internal",
-      "enhance: documentation": "Documentation",
-      "user feedback": "User Feedback"
+      "enhance: documentation": "Documentation"
     }
   },
   "pnpm": {