Added tests and refactored code (Part 3) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t alter existing relative paths
…moveProjectRootFiles step can be more independent of the createFilesFromBlueprint step
ijlee2
added
bug
ijlee2
commented
Jan 19, 2023
Comment on lines
+3
to
+4
| <% if (options.packages.addon.hasGlint) { %> | ||
| import '@glint/environment-ember-loose'; |
There was a problem hiding this comment.
bugfix
Incorrect spacings.
ijlee2
commented
Jan 19, 2023
| @@ -16,7 +16,7 @@ | |||
| "prepare": "npm run build", | |||
| "start": "concurrently 'npm:start:*' --restart-after 5000 --prefix-colors cyan,white,yellow", | |||
| "start:addon": "npm start --workspace <%= options.packages.addon.name %>", | |||
| "start:tests": "npm start --workspace <%= options.packages.testApp.name %>", | |||
| "start:test-app": "npm start --workspace <%= options.packages.testApp.name %>", | |||
There was a problem hiding this comment.
bugfix
Incorrect/inconsistent script names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added tests for the following steps:
moveTestAppFilesmoveProjectRootFilescreateFilesFromBlueprintIn addition, I created test fixtures to thoroughly (and more easily) test
useRelativePathsandcreateFilesFromBlueprint. ForcreateFilesFromBlueprint, where we use evaluations and interpolations to dynamically create files, it's important that we check the file content under various conditions. Note how, in commit 10, we could catch and remove the extra new lines that had been added to_addonLocation__/unpublished-development-types/index.d.tsby mistake.By laying the foundation for testing a step against test fixtures, we will be able to rigorously test
updateAddonPackageJson,updateAddonTsconfigJson,updateTestAppPackageJson, andupdateTestAppTsconfigJsonin the next pull request.