Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed index.ts in tests/fixtures #48

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Allowed index.ts in tests/fixtures #48

merged 1 commit into from
Jun 24, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Jun 24, 2023

Description

In tsconfig.json, I had excluded tests/fixtures so that TypeScript doesn't compile fixture files (since the fixtures files come from somewhere else and aren't something that I, as the codemod author, own). The index.js files, used to convert the input and output directories to JSONs, are mine, however.

It turned out, it is okay to give these index files the *.ts file extension. With the current TypeScript configuration, the project still compiles correctly before the tests are run.

@ijlee2 ijlee2 added the enhance: dependency Issue asks for a new or updated dependency label Jun 24, 2023
@ijlee2 ijlee2 marked this pull request as ready for review June 24, 2023 05:10
@ijlee2 ijlee2 merged commit 0385b2c into main Jun 24, 2023
@ijlee2 ijlee2 deleted the type-index-files branch June 24, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: dependency Issue asks for a new or updated dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant