Updated test fixtures #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry-customizations)
ijlee2
added
the
enhance: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, we use reserved words to quickly denote the type of a fixture project:
customization- represents an end-developer passing--addon-location,--test-app-location, and--test-app-name(any combination thereof)glint- a TypeScript project with Glintjavascript- a JavaScript project without Glinttypescript- a TypeScript project without GlintWe can see these reserved words in the file names in
shared-test-setups.Given the definitions above,
ember-container-query-typescriptis a misnomer because the project has Glint.What changed?
In commits 1-3, I fixed some copy mistakes that I had made during the infancy of this project.
In commit 4, I made a copy of
ember-container-query-typescriptand named the fixture folderember-container-query-glint.In commit 5, I removed references to Glint from
ember-container-query-typescript.