Merge pull request #65 from ZKSI/pg/fixbases

hermitainbasisiterator obeeys its matrix type
iitis · Aug 19, 2019 · dcb33a1 · dcb33a1
2 parents 56c8053 + 46c2d1d
commit dcb33a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/matrixbases.jl b/src/matrixbases.jl
@@ -33,12 +33,13 @@ function iterate(itr::HermitianBasisIterator{T}, state=(1,1)) where T<:AbstractM
     (a, b) = state
     a > dim && return nothing
 
+    Tn = eltype(T)
     if a > b
-        x = 1 / sqrt(2) * (1im * ketbra(a, b, dim) - 1im * ketbra(b, a, dim))
+        x =  (im * ketbra(T, a, b, dim) - im * ketbra(T, b, a, dim)) / sqrt(Tn(2))
     elseif a < b
-        x = 1 / sqrt(2) * (ketbra(a, b, dim) + ketbra(b, a, dim))
+        x = (ketbra(T, a, b, dim) + ketbra(T, b, a, dim)) / sqrt(Tn(2))
     else
-        x = ketbra(a, b, dim)
+        x = ketbra(T, a, b, dim)
     end
     return x, b==dim ? (a+1, 1) : (a, b+1)
 end

diff --git a/test/matrixbases.jl b/test/matrixbases.jl
@@ -8,14 +8,17 @@ end
 
 @testset "represent, combine" begin
     d = 4
-    A = reshape(collect(1:16), 4, 4)
+    A = reshape(collect(1:16), d, d)
     vA = represent(HermitianBasis{Matrix{ComplexF64}}(d), A)
     Ap = combine(HermitianBasis{Matrix{ComplexF64}}(d), vA)
     @test A ≈ Ap
     B = A*A'
     vB = represent(HermitianBasis{Matrix{ComplexF64}}(d), B)
     Bp = combine(HermitianBasis{Matrix{ComplexF64}}(d), vB)
     @test B ≈ Bp
+
+    vB = represent(HermitianBasis{Matrix{ComplexF32}}(d), B)
+    @test eltype(vB) == ComplexF32
 end
 
 end