Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rss link in <head> #11

Merged
merged 3 commits into from
Feb 8, 2015
Merged

Fix rss link in <head> #11

merged 3 commits into from
Feb 8, 2015

Conversation

yqw1218
Copy link
Contributor

@yqw1218 yqw1218 commented Feb 8, 2015

Fix #12

@iissnan iissnan merged commit 487ac8a into iissnan:master Feb 8, 2015
@iissnan
Copy link
Owner

iissnan commented Feb 8, 2015

Thanks! @vinnpc. 👍

I updated the statement theme.rss == '' to use strict comparison. Because theme.rss has 3 scenarios:

  1. false, disable rss link.
  2. ``, empty useconfig.feed
  3. http://feed-url, specific feed url.

theme.rss == '' does not meet the first scenario.

@yqw1218
Copy link
Contributor Author

yqw1218 commented Feb 8, 2015

O... ur right. Must be strict mode. = =

ivan-nginx added a commit that referenced this pull request May 31, 2017
@ivan-nginx
Merge pull request #11 from iissnan/master
8480df6 
Update from original.
wangpei72 pushed a commit to wangpei72/hexo-theme-next that referenced this pull request Sep 17, 2021
@renovate @renovate-bot
Update dependency eslint to v7.1.0 (iissnan#11)
37d2e05 
Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix rss link problem in <head>
2 participants
@yqw1218 @iissnan