-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles override level not localized #4892
Comments
This commit will: - Add key-value pairs for the yes, force and strip override levels to the base and en Localizable.strings files - Change the transformedValue method in the ASSOverrideLevelTransformer class to return a localized string instead of the enum value string This localizes the value displayed for the Override level setting found in the ASS Subtitles section on the Subtitle tab in IINA's settings.
This commit will: - Add key-value pairs for the yes, force and strip override levels to the base and en Localizable.strings files - Change the transformedValue method in the ASSOverrideLevelTransformer class to return a localized string instead of the enum value string This localizes the value displayed for the Override level setting found in the ASS Subtitles section on the Subtitle tab in IINA's settings.
This commit will: - Add key-value pairs for the yes, force and strip override levels to the base and en Localizable.strings files - Change the transformedValue method in the ASSOverrideLevelTransformer class to return a localized string instead of the enum value string This localizes the value displayed for the Override level setting found in the ASS Subtitles section on the Subtitle tab in IINA's settings.
The fix for this issue has been merged into the IINA |
I could not formulate a suitable translation for the "strip" option in my language. Can you help me by using synonyms to find a match? |
Strip means "remove all ASS tags". It will be as if the subtitle file did not include any style tags. |
I'm confused. What does "yes" and "force" mean then? |
Remember I'm not a mpv developer, so I could be wrong…
At least I think this is how the sub-ass-override works. I'm a little confused as well. I was going to look into this some more, but haven't had time yet. So much to do… |
This was fixed in IINA 1.3.5. |
System and IINA version:
Expected behavior:
Where appropriate labels presented to the user are localized.
Actual behavior:
In IINA's settings on the
Subtitle
tab in theASS Subtitles
section theOverride level
setting is controlled by a slider and has a label that displays the slider value as a string. This value is always shown in English. This setting is tied to thempv
sub-ass-override option:IINA is missing support for the
scale
value. That will be a subject for a separate issue.Steps to reproduce:
Open the and click on
System Settings…
Click on the
General
tabUnder
General
click onLanguage & Region
Scroll down to the
Applications
sectionAdd IINA and select a language other than English
Start IINA
Click on
Settings…
(in the languge being used) under theIINA
menuThe settings panel appears
On the left side of the panel click on
Subtitle
In the
ASS Subtitles
section look for the sliderMove the slider and notice the value displayed is in English
MPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: