-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening folder spawns playlist that includes non-media files #4548
Comments
Looks like this was a consequence of the fix for #4434. The logic was changed so that supplying a single folder onto IINA resulted in sending it directly to mpv. It looks like we are being squashed between contradictory requirements here. Doesn't look like mpv does any filtering when it is handed a directory. I did some tests and saw it opening PDFs, and even a What can be done? Off the top of my head:
Or maybe there's a way to ask mpv to do the filtering? Will have to look deeper in the mpv manual but didn't find anything with a quick scan. |
Thank you for the detailed info, @svobs. My unfiltered thoughts include:
I say all this as someone who uses the GUI playlist daily and who has never used the CLI, so of course my perspective reflects that. IINA is awesome, and I have great respect for y’all for all the work you put into making it great! 🌟 |
More than an external tool, mpv is more like the engine which IINA wraps around...or at least that's how some see it. Although there are now so many instances where some limitation of mpv (heh, changing key bindings in real time?) have resulted in IINA going its own way, It's difficult to say where the dividing line is. Obviously the best outcome would be to support as much of mpv's features as possible. But I agree with you it's not desirable to leave the current situation as-is. After thinking about it a bit more, instead of a UI setting as in (3) above, we could add a new command line option to tell IINA send the directory straight to mpv. Something like @low-batt what do you think? |
On my thoughts… First the one @justinmayer is most concerned with. I think this is a regression that must be fixed. I will label it so. On IINA's relationship with mpv… From the main mpv site:
And:
And:
The mpv wiki lists projects providing GUI frontends among them:
(that wiki page will need to be updated with IINA's latest macOS requirements at some point) In IINA's Given this, IINA should strive to be as compatible with mpv as possible. IINA should be very cautious about adding or extending functionality. If IINA adds something on top of mpv then IINA may in the future have to deal with the situation of mpv having added the functionality in a different way. Back to the problem at hand… The mpv project's thoughts on this are expressed in issue mpv-player/mpv#9652. They want you to use a script to remove playlist entries after the fact. As we only want filtering when loading a directory and not in other cases, using a script is not an acceptable solution. Going back to IINA issue #4434, the alternative fix suggested was for IINA to continue to load files itself and support the |
I'm fine with doing that. Small disclaimer: it will have a slightly different outcome than Since I was the author of the original PR I can take ownership of this one. |
Thanks for taking this one. The difference in shuffle behavior sounds fine. We will want to make sure the first video in the playlist is shuffled as well. |
@svobs Where did we end up on this one? The PR is still a draft. |
See my comment in this random place. |
From the above-linked comment:
As one of those affected users (I am still stuck on v1.3.2 as a result), I agree that reverting PR 4439 would be the best short-term solution to this issue. 👍 |
This issue was one of the high priority issues that were supposed to be included in IINA 1.3.4. Unfortunately the 1.3.4 effort crashed into the end of 2023 deadline imposed upon IINA by Open Subtitles to switch to their REST API that connects to their new .com site. There are quite a few issues that were planned for 1.3.4 that did not get finished in time. How to deal with this is currently under discussion. This issue is one of the ones that must be addressed. |
…arg instead (fixes regression: #4548) (#4566) * Handle folder filtering in IINA instead of sending to mpv, and intercept mpv shuffle arg & convert it to playlist-shuffle command. Fixes regression where folder filtering was broken, while still supporting shuffle via cmd-line * Change on_load hook to use main thread, based on feedback * Move shuffle playlist CLI logic from on_load hook to on_before_start_file hook * Refactor shuffle arg handling: add hook only if needed, and add earlier check whether it is still needed. Add some comments, cleanup
The fix for this issue has been merged into the IINA |
Fixed in 1.3.5 |
Opening a folder creates a playlist that includes non-media files that do not belong in playlists.
System and IINA version:
Expected behavior:
Dragging a folder containing a mix of playable media files and non-playable files should result in a playlist that only contains the playable media files. This was the behavior in version 1.3.2 and all IINA versions I have used prior to version 1.3.3.
Actual behavior:
Resulting playlist contains spurious unplayable files. This behavior appears to have started with version 1.3.3.
Steps to reproduce:
Drag a folder containing the following files to the IINA icon in the MacOS dock:
In 1.3.2 and before, the resulting playlist would only include the first three items — the FLAC files.
In 1.3.3, the resulting playlist contains all eight items, including the last five which should not be included. Including the
.m3u
in the playlist is particularly problematic, as it causes the entire album to be played all over again when playback arrives at this item in the list.How often does this happen?
Every time. I had no choice but to revert to version 1.3.2.
The text was updated successfully, but these errors were encountered: