Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FibonacciNumber.cpp #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CoderAayush2104
Copy link

@CoderAayush2104 CoderAayush2104 commented Oct 7, 2022

Fixes #826

By submitting this pull request I confirm I've read and complied with the below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the coding guidelines for this project.
  • My code follows the skeleton code structure.
  • This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once the Travis build passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.
    fibonacci

Copy link
Member

@DhruvDave12 DhruvDave12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is incorrect for the input N = 10 it should be 55 and not 34. It is a minor bug fix it. If you cannot then tell us we will help you.

@CoderAayush2104
Copy link
Author

The code is incorrect for the input N = 10 it should be 55 and not 34. It is a minor bug fix it. If you cannot then tell us we will help you.

Sir but for n = 10 answer is 34 as the series starts from 0. I have also attached the photo of the series.Please review my pull request.
fibonacci

@CoderAayush2104
Copy link
Author

Please merge my request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fibonacci number[CPP]
3 participants