Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop outdated pin of JPype on CI #880

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Drop outdated pin of JPype on CI #880

merged 3 commits into from
Oct 15, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Oct 14, 2024

Today's CI failures somewhat irritate me since we install anaconda and miniconda versions for Python 3.10, and conda info even shows this, but message-ix show-versions then shows that Python version 3.8.20 is used. 3.8 has just reached its end of life, so we can probably drop testing it and the main difference to the runs using newer versions is the pin of JPype 1.2.1.
This version was released almost four years ago now (4.1.2021), so I think it's safe to remove this pin entirely rather than trying to debug the action.

How to review

Please note: this PR contains one commit that temporarily enables the action for this PR; that should be dropped before merging.

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Just CI update.
  • [ ] Add, expand, or update documentation. Just CI update.
  • [ ] Update release notes. Just CI update.

@glatterf42 glatterf42 added the ci Continuous integration label Oct 14, 2024
@glatterf42 glatterf42 self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.5%. Comparing base (7700a82) to head (c0356b6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #880   +/-   ##
=====================================
  Coverage   95.5%   95.5%           
=====================================
  Files         46      46           
  Lines       4340    4340           
=====================================
  Hits        4148    4148           
  Misses       192     192           

@khaeru
Copy link
Member

khaeru commented Oct 14, 2024

3.8 has just reached its end of life, so we can probably drop testing it and the main difference to the runs using newer versions is the pin of JPype 1.2.1.

Rather than “we can probably drop testing [3.8]”, it is our versioning policy to drop support for EOL Pythons and add support for new ones ASAP. This made me check and realize that we don't yet have a PR on message_ix parallel to iiasa/ixmp#544. Is it possible to expand this one to include parallel changes?

@glatterf42
Copy link
Member Author

True, good catch. Most of the required changes should be here now :)
If the tests are successful, I can also declare the 3.13-tests as required instead of 3.12.

@glatterf42
Copy link
Member Author

The current failures arise from failing to build Python-3.13 wheels for pyarrow, which should be fixed once they release v18.0.0, but this has yet to happen.

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, including a rebase to drop the "TEMPORARY" commit.

@glatterf42 glatterf42 merged commit d3cf5bd into main Oct 15, 2024
26 checks passed
@glatterf42 glatterf42 deleted the enh/drop-jpype-ci-pin branch October 15, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants