-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjusted MACRO documentation #27
Conversation
mild revision of MACRO description, including reference to mathematical equations in MESSAGEix documentation
removed MACRO equations from annex and adjusted description of MACRO implementation to MESSAGEix
|
||
MACRO parameterization | ||
---- | ||
---------------------- | ||
|
||
Initial conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section on initial conditions is not specific to global model (part of GAMS code) and therefore should be moved to MACRO part of MESSAGEix documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed here. It may be worthwhile to:
- move this to the MACRO docs
- refer to it
- provide a table of values (as done elsewhere) for each of the 3 SSPs for the global model
|
||
Exchanged parameters | ||
~~~~ | ||
~~~~~~~~~~~~~~~~~~~~ | ||
MESSAGE and MACRO exchange demand levels of the six commercial servcie demand categories represented in MESSAGE, their corresponding prices as well as total energy system costs including | ||
trade effects of energy commodities and carbon permits (if any explicit mititgation effort sharing regime is implemented). | ||
|
||
Convergence criterion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section on convergence is not specific to global model (part of GAMS code) and therefore should be moved to MACRO part of MESSAGEix documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the whole section here could be transferred to the MACRO docs?
Hey @volker-krey, gave the docs a look and all appears well (I'll update if I find anything else to raise awareness of). In general, I think a lot of this text can be moved to the core messageix docs, given that many of the operations are consistent across any implemented message model. Here, I think we should focus on the global-model-specific parameterization (actual numerical values) and their implication on a given result. I'll add my comments inline. |
@@ -200,7 +38,7 @@ setting the labor force index in the base year to 1 (numeraire) and solving for | |||
.. math:: a_r = Y_{y=0, r}^{\rho_r} - \sum_s b_{r,s} \cdot \frac{{{PHYSENE}_{r, s, y=0}}^{\rho_r}} {{K_{y=0, r}}^{\rho_r \cdot \alpha_r}} | |||
|
|||
Macro-economic parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the text here is important. We should probably move the listing of numerical values to a table, though (cleaner to read).
@@ -209,7 +47,7 @@ The capital value share parameter :math:`\alpha_r` can be interpreted as the opt | |||
with lower values between 0.24 and 0.28 assumed for developed regions and slightly higher values of 0.3 assumed for economies in transition and developing country regions. | |||
|
|||
Calibration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be moved out of here and into the generic docs. We may want to refer to the original GDP trajectories (Dellink probably?) and just say that we supplied these trajectories to calibration in .
Hi @volker-krey and @gidden ! I'm Francesco, one of the newcomers to IIASA and as a first task I've been assigned to go through some of the PRs in GitHub in order to eventually merge them to the I've had a glance at the changes made for this PR and based on my very little experience they look fine! Is there anything that still needs to be done on this topic? Could we close and merge this PR to the Thank you 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @volker-krey, if you could implement the changes made in-code by Matt, then this can be resolved.
So, this would be:
- moving suggested sections to MACRO part of MESSAGE documentation
- add reference to GDP trajectories
- write values in a table to have a more clean overview (optional)
No description provided.