-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code quality configuration #555
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=======================================
- Coverage 98.9% 98.9% -0.1%
=======================================
Files 44 44
Lines 4790 4790
=======================================
- Hits 4740 4738 -2
- Misses 50 52 +2
|
@glatterf42 I could, optionally, expand this PR with 2 kinds of improvements to the GitHub Actions workflows that I have prototyped in
Please let me know briefly what you think, and I'll proceed and also make parallel changes to message_ix. |
Thanks for this PR :) I agree with what you say, 1. sounds good, 2. can likely wait a little. Though I have already thought about migrating our package management to |
e3803b6
to
ff7ba2a
Compare
- ruff v1.9.0 → v1.14.1. - Drop custom hook entry that uses PRE_COMMIT_MYPY_VENV. - Use config suggested at python/mypy#13916. - ruff v0.3.4 → v0.9.1 - Reformat 4 files. - Temporarily exclude *.ipynb files covered by new version.
Format 2 files.
- Discard commented workflow contents for pandas 2.0.0 pre-release. - Reduce scope of exclusion for ts-graphviz/setup-graphviz#630 workaround. - Use Python location from setup-uv instead of $pythonLocation. - Drop workaround for pyam-iamc exclusion of Python 3.13. - Add --durations=20 to pytest invocation. - Drop workaround for codecov/codecov-action#1316.
40cfa18
to
ab33b54
Compare
- Drop use of "remotes"; call install.packages() directly. - Install libpng-dev for compiling R 'png' package from source on Linux. - Drop workaround for actions/runner-images#11137; appears no longer necessary.
ab33b54
to
96407b5
Compare
Okay, now in place. Compared to this run:
So only clear daylight on Windows, but by a few minutes. However there's a lot of variability in the unrelated steps. For the ubuntu-latest-py3.13 jobs, the times for the setup step + "Install the package and dependencies":
So that's a clear improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great to me :)
Hopeful that this will stabilize our CI :)
How to review
TBD
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.N/A, formatting onlyUpdate release notes.