-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address GitHub Actions warnings re: node.js 16 #517
Conversation
Suppress warnings about Node.js 16 deprecation. - actions/checkout v3 → v4 - actions/setup-python v4 → v5
Avoid duplicate jobs on release.
- Bump mypy version to 1.8.0. - Bump ruff version 0.0.287 → 0.1.14.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
=======================================
- Coverage 98.9% 98.9% -0.1%
=======================================
Files 44 44
Lines 4795 4795
=======================================
- Hits 4744 4743 -1
- Misses 51 52 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Do we use Node.js anywhere else, i.e. should we bump checkout and setup-python in the other repos as well?
There are at least some warnings for message-ix-models as well.
Yes, we'll need to make similar changes for each repo in the stack. Please let me know if you'd like me to handle certain of those. |
GitHub Actions has started warning about deprecation of Node.js 16, for instance here:
This PR updates 'first-party' actions as suggested:
Per third-party actions:
pending Update action checkout, cache, python pre-commit/action#188it seems this action is actually abandoned and won't receive updates. One alternate approach is to inline the few steps; see e.g. Release v24.2.5 transport-data/tools#14.Other housekeeping:
black
withruff format
for code style (Swapblack
forruff format
in code style/pre-commit message_ix#772).main
(analogous to Save minutes by avoiding duplicate test runs #515).concurrency:
setting to prevent 2 conflicting jobs being started on a release (one triggered by the release event, one by the tag creation event).How to review
Read the diff and note that the CI checks all pass.
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.N/A, CI changes onlyUpdate release notes.