Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address GitHub Actions warnings re: node.js 16 #517

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Address GitHub Actions warnings re: node.js 16 #517

merged 5 commits into from
Jan 30, 2024

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jan 29, 2024

GitHub Actions has started warning about deprecation of Node.js 16, for instance here:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, ts-graphviz/[email protected], r-lib/actions/setup-r@v2, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This PR updates 'first-party' actions as suggested:

  • actions/checkout v3 → v4
  • actions/setup-python v4 → v5

Per third-party actions:

Other housekeeping:

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A, CI changes only
  • Update release notes.

Suppress warnings about Node.js 16 deprecation.

- actions/checkout v3 → v4
- actions/setup-python v4 → v5
Avoid duplicate jobs on release.
@khaeru khaeru self-assigned this Jan 29, 2024
@khaeru khaeru added the ci Continuous integration label Jan 29, 2024
@khaeru khaeru marked this pull request as ready for review January 29, 2024 15:21
- Bump mypy version to 1.8.0.
- Bump ruff version 0.0.287 → 0.1.14.
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a2aa91) 98.9% compared to head (8679d00) 98.9%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #517     +/-   ##
=======================================
- Coverage   98.9%   98.9%   -0.1%     
=======================================
  Files         44      44             
  Lines       4795    4795             
=======================================
- Hits        4744    4743      -1     
- Misses        51      52      +1     
Files Coverage Δ
ixmp/tests/test_model.py 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

@khaeru khaeru requested a review from glatterf42 January 29, 2024 16:53
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
Do we use Node.js anywhere else, i.e. should we bump checkout and setup-python in the other repos as well?
There are at least some warnings for message-ix-models as well.

@khaeru
Copy link
Member Author

khaeru commented Jan 30, 2024

Yes, we'll need to make similar changes for each repo in the stack. Please let me know if you'd like me to handle certain of those.

@khaeru khaeru merged commit 9b93531 into main Jan 30, 2024
21 checks passed
@khaeru khaeru deleted the gha-node-20 branch January 30, 2024 07:55
@glatterf42 glatterf42 mentioned this pull request Feb 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants