Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset mixer on each focus update #3771

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

oleg-derevenetz
Copy link
Collaborator

@oleg-derevenetz oleg-derevenetz commented Jun 28, 2021

Regression introduced in #3768. This leads to an issue when all terrain music and ambient sounds start from the beginning after each hero movement or action.

@oleg-derevenetz oleg-derevenetz added regression Something went wrong in previous commits audio Sound and music related stuff labels Jun 28, 2021
@oleg-derevenetz oleg-derevenetz added this to the 0.9.5 milestone Jun 28, 2021
@oleg-derevenetz oleg-derevenetz requested a review from ihhub June 28, 2021 20:04
@oleg-derevenetz oleg-derevenetz linked an issue Jun 29, 2021 that may be closed by this pull request
@ihhub ihhub merged commit d0efeea into ihhub:master Jun 29, 2021
@ihhub
Copy link
Owner

ihhub commented Jun 29, 2021

@oleg-derevenetz , thanks a lot for fixing it!

@oleg-derevenetz oleg-derevenetz deleted the focus-change-mixer-reset-fix branch July 2, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio Sound and music related stuff regression Something went wrong in previous commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sound problem while hero is moving on the adventure map
2 participants