Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more detail display for morale and luck #2925

Merged
merged 2 commits into from
Mar 15, 2021
Merged

more detail display for morale and luck #2925

merged 2 commits into from
Mar 15, 2021

Conversation

undef21
Copy link
Contributor

@undef21 undef21 commented Mar 8, 2021

related issue #2808

@idshibanov idshibanov added improvement New feature, request or improvement ui UI/GUI related stuff labels Mar 8, 2021
@idshibanov idshibanov added this to the 0.9.2 milestone Mar 8, 2021
ihhub
ihhub requested changes Mar 15, 2021
View reviewed changes
Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @undef21 , I left just one comment. Please take a look.

src/fheroes2/heroes/heroes_indicator.h Outdated Show resolved Hide resolved
@ihhub ihhub merged commit bcd71e2 into ihhub:master Mar 15, 2021
@ihhub
Copy link
Owner

ihhub commented Mar 15, 2021

@undef21 , a bunch of thanks for fixing this issue!

@undef21 undef21 deleted the morale_and_luck branch March 15, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihhub ihhub ihhub requested changes

Assignees

@undef21 undef21

Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@undef21 @ihhub @idshibanov