avoid the extreme case that notify missing

ihaolin · Oct 15, 2016 · 6150509 · 6150509
1 parent 7e7bb42
commit 6150509
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 16 deletions.
diff --git a/diablo-client-spring/pom.xml b/diablo-client-spring/pom.xml
@@ -3,7 +3,7 @@
     <parent>
         <artifactId>diablo</artifactId>
         <groupId>me.hao0</groupId>
-        <version>1.1.0</version>
+        <version>1.1.1</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 
@@ -22,7 +22,7 @@
         <dependency>
             <groupId>me.hao0</groupId>
             <artifactId>diablo-client</artifactId>
-            <version>1.1.0</version>
+            <version>1.1.1</version>
         </dependency>
 
         <dependency>

diff --git a/diablo-client/pom.xml b/diablo-client/pom.xml
@@ -3,7 +3,7 @@
     <parent>
         <artifactId>diablo</artifactId>
         <groupId>me.hao0</groupId>
-        <version>1.1.0</version>
+        <version>1.1.1</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 
@@ -22,7 +22,7 @@
         <dependency>
             <groupId>me.hao0</groupId>
             <artifactId>diablo-common</artifactId>
-            <version>1.1.0</version>
+            <version>1.1.1</version>
         </dependency>
 
         <!-- use slf4j-api for logging -->

diff --git a/diablo-common/pom.xml b/diablo-common/pom.xml
@@ -3,7 +3,7 @@
     <parent>
         <artifactId>diablo</artifactId>
         <groupId>me.hao0</groupId>
-        <version>1.1.0</version>
+        <version>1.1.1</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

diff --git a/diablo-server/pom.xml b/diablo-server/pom.xml
@@ -3,7 +3,7 @@
     <parent>
         <artifactId>diablo</artifactId>
         <groupId>me.hao0</groupId>
-        <version>1.1.0</version>
+        <version>1.1.1</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 
@@ -22,7 +22,7 @@
         <dependency>
             <groupId>me.hao0</groupId>
             <artifactId>diablo-common</artifactId>
-            <version>1.1.0</version>
+            <version>1.1.1</version>
         </dependency>
 
         <dependency>

diff --git a/diablo-server/src/main/java/me/hao0/diablo/server/support/PullingSupport.java b/diablo-server/src/main/java/me/hao0/diablo/server/support/PullingSupport.java
@@ -149,13 +149,8 @@ public void run() {
             if (sendUpdatedConfigsIfPossible(client.getAppId(), pullingConfigs, response)){
                 // updated config sent
 
-                // complete async context to tell the container sends response
-                asyncContext.complete();
-
-                // cancel data changed listening
-                if (pullingTimeoutFuture != null){
-                    pullingTimeoutFuture.cancel(false);
-                }
+                // stop pulling
+                stopPulling();
 
             } else {
                 // no updated config sent
@@ -164,13 +159,17 @@ public void run() {
                 int serverKeepPullingTimeout = getPullingTimeout((HttpServletRequest) asyncContext.getRequest());
                 pullingTimeoutFuture = longPullingScheduler.schedule(new Runnable() {
                     public void run() {
-                        Logs.info("client pulling is timeout.");
                         stopPulling();
                     }
                 }, serverKeepPullingTimeout, TimeUnit.SECONDS);
 
                 // start to listen config updated
                 eventDispatcher.register(this);
+
+                // NOTE: avoid the extreme case that config updated notify before registering self
+                if (sendUpdatedConfigsIfPossible(client.getAppId(), pullingConfigs, response)){
+                    stopPulling();
+                }
             }
         }
 
@@ -203,6 +202,11 @@ private void stopPulling() {
 
             // tell the container to send response
             asyncContext.complete();
+
+            // cancel data changed listening
+            if (pullingTimeoutFuture != null){
+                pullingTimeoutFuture.cancel(false);
+            }
         }
 
         /**

diff --git a/pom.xml b/pom.xml
@@ -13,7 +13,7 @@
 
     <groupId>me.hao0</groupId>
     <artifactId>diablo</artifactId>
-    <version>1.1.0</version>
+    <version>1.1.1</version>
     <modules>
         <module>diablo-common</module>
         <module>diablo-server</module>