Fix Merged track popup bug #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, that was inadvertent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! First of all, thanks for all the work you've been putting into igv.js and all the new releases!!
One thing I noticed is a small bug in Merged Track popup which prevents it from displaying (see the screenshots).
This was probably partly introduced by myself not highlighting why I added a new parameter (trackNames) to the MergedFeatureCollection class when I previously worked on this. You've probably deleted it while cleaning the code but it is important for the popup data as it is used to display track names in the order of the actual tracks in the popup. I've reintroduced it and added a comment that should hopefully make it clearer.
Let me know if this breaks anything I am missing to see.
Edit: another side thing, we should perhaps think about updating eslint to newer version and then updating the ecmaVersion as it complains about static class properties as it is now.