Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update GML test file #925

Merged
merged 1 commit into from
Oct 29, 2023
Merged

test: Update GML test file #925

merged 1 commit into from
Oct 29, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Oct 29, 2023

.

@krlmlr krlmlr requested a review from szhorvat October 29, 2023 10:25
@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 29, 2023

What is the effect of this change?

@szhorvat
Copy link
Member

The file was invalid, as it contained an unencoded & character. igraph reads this without problems, but it issues a warning. This change got rid of the warning.

(The GML parser got some major improvements in 0.10.)

@krlmlr krlmlr merged commit 6e8cde7 into main Oct 29, 2023
12 checks passed
@krlmlr krlmlr deleted the f-test-football branch October 29, 2023 15:35
@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 29, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szhorvat szhorvat Awaiting requested review from szhorvat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @szhorvat