Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose find_cycle() #1571

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: expose find_cycle() #1571

wants to merge 5 commits into from

Conversation

szhorvat
Copy link
Member

@szhorvat szhorvat commented Nov 4, 2024

Closes #1471

@szhorvat szhorvat requested a review from krlmlr November 4, 2024 19:17
Copy link
Contributor

aviator-app bot commented Nov 4, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat
Copy link
Member Author

szhorvat commented Nov 4, 2024

Need to merge #1568 to deal with the CI failure.

@szhorvat szhorvat force-pushed the feat/find_cycle branch 3 times, most recently from d50bd51 to 999e3a6 Compare November 10, 2024 12:10
@szhorvat
Copy link
Member Author

@krlmlr After rebasing and fixing an example, tests pass now. Merging this will allow me to expose simple_cycles() as well, which I expect will be a popular function.

interface: default OUT mode for igraph_find_cycle()
refactor: better error reporting for igraph_find_cycle()
chore: some copyright header cleanup in public headers
refactor: minor readability improvements
fix: add some missing IGRAPH_CHECKs
refactor: minor readability cleanup in matching functions
fix: `igraph_bipartite_projection_size()` now validates the bipartite `types` vector
chore: fix some spelling mistakes
refactor: minor readability cleanup in igraph_decompose()
doc: more documentation improvements
doc: several documentation improvements and cross-referencing
chore: fix typo in error message
docs: community_optimal_modulairty() does support directed graphs
chore: do not warn about unknown warning options with legacy Intel compiler
fix: validate sample size in igraph_motifs_randesu_estimate()
chore: fix typo in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add igraph_find_cycle()
2 participants