Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update room permissions leads to conflicts #159

Closed
guusdk opened this issue Nov 1, 2022 · 0 comments
Closed

Update room permissions leads to conflicts #159

guusdk opened this issue Nov 1, 2022 · 0 comments

Comments

@guusdk
Copy link
Member

guusdk commented Nov 1, 2022

When a room's user permissions are being updated, conflicts arise (but are not logged).

It appears that the implementation first removes all permissions, to then update them to the desired configuration.

This intermediate step briefly removes all owners, which is forbidden (a room must always have an owner), causing a conflict.

guusdk added a commit to guusdk/openfire-restAPI-plugin that referenced this issue Nov 1, 2022
guusdk added a commit that referenced this issue Nov 1, 2022
guusdk added a commit to guusdk/openfire-restAPI-plugin that referenced this issue Nov 1, 2022
Issues pop up when an attempt is ade to affiliate a JID more than once, especially when that JID is also an owner. Affiliating such a JID as something else will remove the ownership affiliation. This can trigger an issue where the room has no owners.

This commit introduces a check to verify that the inbound request does not define multiple affiliations for the same JID. It also reworks the way in which affiliations are applied.
@guusdk guusdk closed this as completed in a990316 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant