Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add multi node (validator) testnet (backport #4377) #4398

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 8, 2024

Closes: #4374

This PR added the feature to ignite multi-node testnet.

Test steps:

  1. ignite scaffold chain github.com/test/mychain
  2. cd mychain
  3. go install ./...
  4. ignite testnet multi-node

The interface looks like this:

image
This is an automatic backport of pull request #4377 done by [Mergify](https://mergify.com).

* add cmd multi-node

* read config

* minor

* init node

* done

* remove try

* updates

* updates

* make format

* updates

* minor

* rename and add info node

* add a reset command

* changelog

* lint

* use config.yml with more validators

* updates docs

* show log

* rename package model to bubblemodel

* Update ignite/cmd/testnet_multi_node.go

Co-authored-by: Julien Robert <[email protected]>

* nits

* Update ignite/cmd/bubblemodel/testnet_multi_node.go

Co-authored-by: Danilo Pantani <[email protected]>

* Update ignite/cmd/bubblemodel/testnet_multi_node.go

Co-authored-by: Danilo Pantani <[email protected]>

* Update ignite/cmd/bubblemodel/testnet_multi_node.go

Co-authored-by: Danilo Pantani <[email protected]>

* Update ignite/cmd/testnet_multi_node.go

Co-authored-by: Danilo Pantani <[email protected]>

* updates

* use lipgloss for View

* status bar

* nits

* Update ignite/cmd/bubblemodel/testnet_multi_node.go

Co-authored-by: Danilo Pantani <[email protected]>

* Update ignite/cmd/bubblemodel/testnet_multi_node.go

Co-authored-by: Danilo Pantani <[email protected]>

* remove ctx

* add comment

* use ports in ignite/pkg/availableport/availableport.go

* update errgroup

* Update changelog.md

Co-authored-by: Danilo Pantani <[email protected]>

* updates with v0.52

---------

Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Danilo Pantani <[email protected]>
(cherry picked from commit b7e3ab3)

# Conflicts:
#	docs/docs/03-CLI-Commands/01-cli-commands.md
#	ignite/cmd/bubblemodel/chain_debug_test.go
#	ignite/cmd/bubblemodel/chain_serve_test.go
#	ignite/cmd/chain_debug.go
#	ignite/cmd/chain_serve.go
#	ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/commands.go.plush
Copy link
Contributor Author

mergify bot commented Nov 8, 2024

Cherry-pick of b7e3ab3 has failed:

On branch mergify/bp/release/v28.x.y/pr-4377
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit b7e3ab3c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	renamed:    ignite/cmd/model/chain_debug.go -> ignite/cmd/bubblemodel/chain_debug.go
	renamed:    ignite/cmd/model/chain_serve.go -> ignite/cmd/bubblemodel/chain_serve.go
	renamed:    ignite/cmd/model/testdata/testdata.go -> ignite/cmd/bubblemodel/testdata/testdata.go
	new file:   ignite/cmd/bubblemodel/testnet_multi_node.go
	deleted:    ignite/cmd/model/chain_debug_test.go
	deleted:    ignite/cmd/model/chain_serve_test.go
	modified:   ignite/cmd/testnet.go
	new file:   ignite/cmd/testnet_multi_node.go
	modified:   ignite/config/chain/v1/config.go
	modified:   ignite/pkg/chaincmd/chaincmd.go
	modified:   ignite/pkg/chaincmd/in-place-testnet.go
	modified:   ignite/pkg/chaincmd/runner/chain.go
	modified:   ignite/pkg/markdownviewer/markdownviewer.go
	modified:   ignite/services/chain/runtime.go
	modified:   ignite/services/chain/testnet.go
	new file:   ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush
	modified:   ignite/templates/app/files/config.yml.plush

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/docs/03-CLI-Commands/01-cli-commands.md
	both modified:   ignite/cmd/bubblemodel/chain_debug_test.go
	both modified:   ignite/cmd/bubblemodel/chain_serve_test.go
	both modified:   ignite/cmd/chain_debug.go
	both modified:   ignite/cmd/chain_serve.go
	both modified:   ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/commands.go.plush

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from ilgooz as a code owner November 8, 2024 12:18
@mergify mergify bot added the conflicts label Nov 8, 2024
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:templates component:configs component:cmd type:services Service-related issues. type:internal component:packages labels Nov 8, 2024
@julienrbrt
Copy link
Member

Hey @likesToEatFish, could you open a PR making it work with v28 (0.50).
You had that first before main migrated to v0.52. Thanks!

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Visit the preview URL for this PR (updated for commit 2b99ece):

https://igntservices-docs--pr4398-mergify-bp-release-v-5qcykn5t.web.app

(expires Thu, 21 Nov 2024 14:49:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@likesToEatFish
Copy link
Contributor

Hey @likesToEatFish, could you open a PR making it work with v28 (0.50). You had that first before main migrated to v0.52. Thanks!

ok let me

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@julienrbrt julienrbrt merged commit 0155415 into release/v28.x.y Nov 14, 2024
42 of 45 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4377 branch November 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:docs Documentation additions or improvements. component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants