Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golangci-lint to v1.60.3 (backport #4324) #4333

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 29, 2024


This is an automatic backport of pull request #4324 done by [Mergify](https://mergify.com).

* bump golangci-lint to `v1.60.3`

* run mod tidy

(cherry picked from commit 8a038fc)

# Conflicts:
#	.github/workflows/test-lint.yml
#	go.mod
#	go.sum
@mergify mergify bot requested a review from ilgooz as a code owner August 29, 2024 22:53
@mergify mergify bot added the conflicts label Aug 29, 2024
Copy link
Contributor Author

mergify bot commented Aug 29, 2024

Cherry-pick of 8a038fc has failed:

On branch mergify/bp/release/v28.x.y/pr-4324
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 8a038fc9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/test-lint.yml
	both modified:   go.mod
	both modified:   go.sum

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Aug 29, 2024
@Pantani
Copy link
Collaborator

Pantani commented Aug 30, 2024

Backporting this so we can have the CI working again into the release branch

@Pantani Pantani added the skip-changelog Don't check changelog for new entries label Aug 30, 2024
@julienrbrt
Copy link
Member

No need to backport this.

@julienrbrt julienrbrt closed this Aug 30, 2024
@mergify mergify bot deleted the mergify/bp/release/v28.x.y/pr-4324 branch August 30, 2024 08:00
@Pantani
Copy link
Collaborator

Pantani commented Aug 30, 2024

the lint into the release branch is also broken, the PR's will not pass the CI

@julienrbrt
Copy link
Member

we can bump in CI, but no need to bump in ignite itself imho.

@julienrbrt
Copy link
Member

1.60.3 adds more linter, so we would have to fix more linting issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs conflicts skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants