feat: prepare for wasm app #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
github-actions
bot
added
component:ci
jeronimoalbi
reviewed
Feb 8, 2024
jeronimoalbi
approved these changes
Feb 8, 2024
julienrbrt
approved these changes
Feb 8, 2024
RaulBernal
added a commit
to BitCannaGlobal/bcna
that referenced
this pull request
Feb 9, 2024
Pantani
added
backport/v28.x.y
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
### Description - Pass the `servertypes.AppOptions` to the `registerIBCModules` function so we can use it in the wasm integration app; - Return an error for `registerIBCModules` instead panic; (cherry picked from commit 1e63bb6)
julienrbrt
added a commit
that referenced
this pull request
Mar 12, 2024
* feat: prepare for wasm app (#3956) ### Description - Pass the `servertypes.AppOptions` to the `registerIBCModules` function so we can use it in the wasm integration app; - Return an error for `registerIBCModules` instead panic; (cherry picked from commit 1e63bb6) * changelog fix --------- Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
### Description - Pass the `servertypes.AppOptions` to the `registerIBCModules` function so we can use it in the wasm integration app; - Return an error for `registerIBCModules` instead panic;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
servertypes.AppOptionsto theregisterIBCModulesfunction so we can use it in the wasm integration app;registerIBCModulesinstead panic;