feat: support cosmos-sdk local fork #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
julienrbrt
force-pushed
the
julien/local-fork
branch
from
13a2f47 to
317d940
Compare
julienrbrt
force-pushed
the
julien/local-fork
branch
from
317d940 to
58d7e9e
Compare
julienrbrt
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi,
Pantani and
Ehsan-saradar
as code owners
|
@julienrbrt thanks for the quick resolution on this. do you think we can have this merged and available in the nightly build this week? |
Hopefully, I just need some reviewers here. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3878 +/- ##
==========================================
+ Coverage 24.37% 24.41% +0.04%
==========================================
Files 294 294
Lines 24547 24562 +15
==========================================
+ Hits 5984 5998 +14
Misses 18027 18027
- Partials 536 537 +1
|
jeronimoalbi
previously approved these changes
Jan 12, 2024
jeronimoalbi
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3875
As per the issue described, using a local fork does not work since v28.
Using a remote fork has been fixed in a previous PR (#3833).
I have well found some issue with the local module detection and buf handling, which is resolved here as well.