Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg/protoanalysis): support HTTP rule parameter arguments #3592

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

jeronimoalbi
Copy link
Member

Proto HTTP rule parameters can have extra arguments which are defined after a "=", for example /foo/{bar=**}.

Fixes #3554

Proto HTTP rule parameters can have extra arguments which are defined
after a "=", for example "/foo/{bar=**}".
@jeronimoalbi jeronimoalbi added the type:bug Something isn't working label Jul 25, 2023
@jeronimoalbi jeronimoalbi requested a review from ilgooz as a code owner July 25, 2023 09:44
@jeronimoalbi jeronimoalbi self-assigned this Jul 25, 2023
@jeronimoalbi jeronimoalbi requested a review from Pantani as a code owner July 25, 2023 09:44
@jeronimoalbi jeronimoalbi marked this pull request as draft July 25, 2023 10:00
@jeronimoalbi jeronimoalbi marked this pull request as ready for review July 25, 2023 10:15
@jeronimoalbi
Copy link
Member Author

Test should be fixed once #3595 is merged

@jeronimoalbi jeronimoalbi merged commit e0215e3 into main Jul 26, 2023
@jeronimoalbi jeronimoalbi deleted the fix/proto-http-rule-parameter-expr branch July 26, 2023 09:56
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
…#3592)

* fix(pkg/protoanalysis): support HTTP rule parameter arguments

Proto HTTP rule parameters can have extra arguments which are defined
after a "=", for example "/foo/{bar=**}".

* chore: update changelog

---------

Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: Compilation error in generated React Hooks code
3 participants