Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove indentation from chain serve output to make it easier to properly copy and paste #3522

Merged
merged 12 commits into from
Jul 20, 2023

Conversation

derickmr
Copy link
Contributor

Resolves #3363

Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @derickmr
Only a few comments, and thanks for adding more tests also!

ignite/pkg/cliui/view/accountview/account_test.go Outdated Show resolved Hide resolved
ignite/pkg/cliui/view/accountview/account_test.go Outdated Show resolved Hide resolved
@derickmr derickmr requested a review from Pantani May 31, 2023 10:53
Pantani
Pantani previously approved these changes May 31, 2023
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!!

Thanks @derickmr

@Pantani
Copy link
Collaborator

Pantani commented May 31, 2023

@derickmr can you please add a changelog for it please?

@derickmr derickmr changed the title chore: remove identation from chain serve output to make it easier to properly copy and paste chore: remove indentation from chain serve output to make it easier to properly copy and paste May 31, 2023
@derickmr
Copy link
Contributor Author

@derickmr can you please add a changelog for it please?

ops, I missed that. changelog added

@derickmr derickmr requested a review from Pantani May 31, 2023 14:42
Pantani
Pantani previously approved these changes Jun 1, 2023
@derickmr derickmr requested review from jeronimoalbi and Pantani June 2, 2023 13:11
Pantani
Pantani previously approved these changes Jun 2, 2023
jeronimoalbi
jeronimoalbi previously approved these changes Jun 2, 2023
@Pantani Pantani dismissed stale reviews from jeronimoalbi and themself via e720485 June 13, 2023 12:38
@Pantani Pantani requested a review from jeronimoalbi July 4, 2023 21:54
@Pantani Pantani self-requested a review July 4, 2023 21:54
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #3522 (15cf370) into main (7b93008) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
+ Coverage   24.22%   24.33%   +0.11%     
==========================================
  Files         298      298              
  Lines       23754    23751       -3     
==========================================
+ Hits         5754     5780      +26     
+ Misses      17487    17458      -29     
  Partials      513      513              
Impacted Files Coverage Δ
ignite/pkg/cliui/view/accountview/account.go 59.45% <100.00%> (+59.45%) ⬆️

... and 1 file with indirect coverage changes

@jeronimoalbi jeronimoalbi merged commit a991ee2 into ignite:main Jul 20, 2023
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
…o properly copy and paste (ignite#3522)

* chore: remove identation from chain serve output to make it easier to properly copy and paste

* refactor: accountview tests to follow tt patterns

* fix: adding missing changelog for chain serve indentation changes

* refactor: following naming convention on tests for account string

Co-authored-by: Jerónimo Albi <[email protected]>

---------

Co-authored-by: Derick Rentz <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serve: output makes it hard to copy/paste mnemonic
3 participants