-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove indentation from chain serve output to make it easier to properly copy and paste #3522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @derickmr
Only a few comments, and thanks for adding more tests also!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!!
Thanks @derickmr
Co-authored-by: Jerónimo Albi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3522 +/- ##
==========================================
+ Coverage 24.22% 24.33% +0.11%
==========================================
Files 298 298
Lines 23754 23751 -3
==========================================
+ Hits 5754 5780 +26
+ Misses 17487 17458 -29
Partials 513 513
|
…o properly copy and paste (ignite#3522) * chore: remove identation from chain serve output to make it easier to properly copy and paste * refactor: accountview tests to follow tt patterns * fix: adding missing changelog for chain serve indentation changes * refactor: following naming convention on tests for account string Co-authored-by: Jerónimo Albi <[email protected]> --------- Co-authored-by: Derick Rentz <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: Danilo Pantani <[email protected]>
Resolves #3363