fix: interrupt plugin commands #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
requested review from
lumtis,
jeronimoalbi,
aljo242,
fadeev and
Pantani
as code owners
Due to the plugin architecture, the user wasn't able to interrupt a plugin command via Ctrl+C. This is annoying if the plugin execution is long. By running the plugin execution in a goroutine and by listening to the command context at the same time, we can fix that.
tbruyelle
force-pushed
the
fix/interrupt-plugin-cmd
branch
from
27eac59 to
e64a36a
Compare
jeronimoalbi
approved these changes
Dec 2, 2022
Well, w/o modification in |
aljo242
approved these changes
Dec 5, 2022
Codecov ReportBase: 19.94% // Head: 19.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3222 +/- ##
==========================================
+ Coverage 19.94% 19.97% +0.02%
==========================================
Files 382 382
Lines 30101 30108 +7
==========================================
+ Hits 6004 6014 +10
+ Misses 23521 23519 -2
+ Partials 576 575 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aljo242
pushed a commit
that referenced
this pull request
Dec 6, 2022
Due to the plugin architecture, the user wasn't able to interrupt a plugin command via Ctrl+C. This is annoying if the plugin execution is long. By running the plugin execution in a goroutine and by listening to the command context at the same time, we can fix that. Co-authored-by: Alex Johnson <[email protected]>
aljo242
added a commit
that referenced
this pull request
Dec 7, 2022
* vuln and math * go-git * go-yaml * mockery + regen * grpc * chore(docs): docs v0.25.2 (latest) and nightly (#3206) * chore(docs): docs v0.25.2 (latest) and nightly * chore: add versionning documentation * chore(ci): generate docs on new release Co-authored-by: Alex Johnson <[email protected]> * docs: "Hello, World!" tutorial rewrite (#3218) * Getting started * fix: dir name * proto in cosmos sdk * query wip * finish the hello tutorial * added a paragraph about default module * chore: apply mdgofmt on docs Had to re-apply the fixes I did on the docs to the `versioned_docs` version. Co-authored-by: Thomas Bruyelle <[email protected]> * docs: fix path in hello tutorial (#3226) * docs: fix path in hello tutorial * formatting * refactor(`config`): organization (#3202) * base * base refactor * refactor * rename * rename * fix comment * rename file * format * refactor base * format * refactor some imports * imports refactor * fix * fix import * refactor: * changelog * changelog * Update ignite/services/network/networkchain/init.go Co-authored-by: Jerónimo Albi <[email protected]> * base -> baseconfig * refactoring for clarity * v12 -> v1 * fix tests * fix integration * fix name * fix integration * format * Update ignite/cmd/cmd.go Co-authored-by: Jerónimo Albi <[email protected]> * imports * LocateDefault logic * lint fix * refactor and test * finish refactor * revert * move * move * rename * fix tests * fix test * fix error statement for global plugins * typo * chainconfig * imports * fix imports * address review * testdata * better import * fix test * fix Co-authored-by: Jerónimo Albi <[email protected]> * feat(CI): add codecov coverage (#3220) * add codecov coverage * create a new script file for the coverage test and put the coverage file into the .gitignore Co-authored-by: Alex Johnson <[email protected]> * feat(plugin): support plugin path with hash (#3217) * feat(plugin): support plugin path with hash Move the clone logic to xgit.Clone so it can be used for instance in the `network chain publish` command. In the future it could also support private repos. * improve code format * remove useless TODO Co-authored-by: Alex Johnson <[email protected]> * fix: interrupt plugin commands (#3222) Due to the plugin architecture, the user wasn't able to interrupt a plugin command via Ctrl+C. This is annoying if the plugin execution is long. By running the plugin execution in a goroutine and by listening to the command context at the same time, we can fix that. Co-authored-by: Alex Johnson <[email protected]> * docs: added manual section to the hello tutorial (#3227) * docs: added manual section to the hello tutorial * fix: formatting * fix: formatting * ignite generate proto-go * fix: remove grpc_ prefix * add ignite chain serve * fix: phrasing when new files are created * Update docs/docs/guide/03-hello.md Co-authored-by: Alex Johnson <[email protected]> * Update docs/docs/guide/03-hello.md Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Alex Johnson <[email protected]> * fix: removed grpc_* prefix from query files in scaffolded chain (#3224) * Removed grpc_* prefix from query files in scaffolded chain * modified:changelog.md * modified:changelog.md * Removed grpc_* prefix from query files in scaffolded chain Co-authored-by: Alex Johnson <[email protected]> * chore: go formatting (#3232) Co-authored-by: aljo242 <[email protected]> * docs(cli): update generated docs (#3207) Co-authored-by: aljo242 <[email protected]> Co-authored-by: Alex Johnson <[email protected]> * chore(docs): Fix some broken links and add a link checker for the markdown files (#3219) * Fix some broken links and add a link checker for the markdown files * add md link checker config * fix broken links * remove redirect links from checker * remove redirect links from checker * remove duplicated config * remove babylon blockchain link and change master to main for cosmos-sdk docs * fix broken links * remove sdk modules links because the redirection * github moved links * github moved links * fix local links * remove atom ide * ignite guides * add link checkr configs * remove unused slash for urls * exclude github 403 result links * fix github link Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Albert Le Batteux <[email protected]> Co-authored-by: Denis Fadeev <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]> Co-authored-by: Saumya <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: aljo242 <[email protected]>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Due to the plugin architecture, the user wasn't able to interrupt a plugin command via Ctrl+C. This is annoying if the plugin execution is long. By running the plugin execution in a goroutine and by listening to the command context at the same time, we can fix that. Co-authored-by: Alex Johnson <[email protected]>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* vuln and math * go-git * go-yaml * mockery + regen * grpc * chore(docs): docs v0.25.2 (latest) and nightly (ignite#3206) * chore(docs): docs v0.25.2 (latest) and nightly * chore: add versionning documentation * chore(ci): generate docs on new release Co-authored-by: Alex Johnson <[email protected]> * docs: "Hello, World!" tutorial rewrite (ignite#3218) * Getting started * fix: dir name * proto in cosmos sdk * query wip * finish the hello tutorial * added a paragraph about default module * chore: apply mdgofmt on docs Had to re-apply the fixes I did on the docs to the `versioned_docs` version. Co-authored-by: Thomas Bruyelle <[email protected]> * docs: fix path in hello tutorial (ignite#3226) * docs: fix path in hello tutorial * formatting * refactor(`config`): organization (ignite#3202) * base * base refactor * refactor * rename * rename * fix comment * rename file * format * refactor base * format * refactor some imports * imports refactor * fix * fix import * refactor: * changelog * changelog * Update ignite/services/network/networkchain/init.go Co-authored-by: Jerónimo Albi <[email protected]> * base -> baseconfig * refactoring for clarity * v12 -> v1 * fix tests * fix integration * fix name * fix integration * format * Update ignite/cmd/cmd.go Co-authored-by: Jerónimo Albi <[email protected]> * imports * LocateDefault logic * lint fix * refactor and test * finish refactor * revert * move * move * rename * fix tests * fix test * fix error statement for global plugins * typo * chainconfig * imports * fix imports * address review * testdata * better import * fix test * fix Co-authored-by: Jerónimo Albi <[email protected]> * feat(CI): add codecov coverage (ignite#3220) * add codecov coverage * create a new script file for the coverage test and put the coverage file into the .gitignore Co-authored-by: Alex Johnson <[email protected]> * feat(plugin): support plugin path with hash (ignite#3217) * feat(plugin): support plugin path with hash Move the clone logic to xgit.Clone so it can be used for instance in the `network chain publish` command. In the future it could also support private repos. * improve code format * remove useless TODO Co-authored-by: Alex Johnson <[email protected]> * fix: interrupt plugin commands (ignite#3222) Due to the plugin architecture, the user wasn't able to interrupt a plugin command via Ctrl+C. This is annoying if the plugin execution is long. By running the plugin execution in a goroutine and by listening to the command context at the same time, we can fix that. Co-authored-by: Alex Johnson <[email protected]> * docs: added manual section to the hello tutorial (ignite#3227) * docs: added manual section to the hello tutorial * fix: formatting * fix: formatting * ignite generate proto-go * fix: remove grpc_ prefix * add ignite chain serve * fix: phrasing when new files are created * Update docs/docs/guide/03-hello.md Co-authored-by: Alex Johnson <[email protected]> * Update docs/docs/guide/03-hello.md Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Alex Johnson <[email protected]> * fix: removed grpc_* prefix from query files in scaffolded chain (ignite#3224) * Removed grpc_* prefix from query files in scaffolded chain * modified:changelog.md * modified:changelog.md * Removed grpc_* prefix from query files in scaffolded chain Co-authored-by: Alex Johnson <[email protected]> * chore: go formatting (ignite#3232) Co-authored-by: aljo242 <[email protected]> * docs(cli): update generated docs (ignite#3207) Co-authored-by: aljo242 <[email protected]> Co-authored-by: Alex Johnson <[email protected]> * chore(docs): Fix some broken links and add a link checker for the markdown files (ignite#3219) * Fix some broken links and add a link checker for the markdown files * add md link checker config * fix broken links * remove redirect links from checker * remove redirect links from checker * remove duplicated config * remove babylon blockchain link and change master to main for cosmos-sdk docs * fix broken links * remove sdk modules links because the redirection * github moved links * github moved links * fix local links * remove atom ide * ignite guides * add link checkr configs * remove unused slash for urls * exclude github 403 result links * fix github link Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Albert Le Batteux <[email protected]> Co-authored-by: Denis Fadeev <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]> Co-authored-by: Saumya <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: aljo242 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the plugin architecture, the user wasn't able to interrupt a plugin command via Ctrl+C. This is annoying if the plugin execution is long.
By running the plugin execution in a goroutine and by listening to the command context at the same time, we can fix that.