Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tooling updates #2847

Merged
merged 3 commits into from
Sep 21, 2022
Merged

chore: tooling updates #2847

merged 3 commits into from
Sep 21, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 21, 2022 •
edited
Loading

  • update CI workflows to use latest go version (1.19) and checkout actions (v3)
  • update CI lint tool and rules
  • add govulncheck
  • minor go vet fix

@aljo242 aljo242 added the skip-changelog Don't check changelog for new entries label Sep 21, 2022
@tbruyelle
Copy link
Contributor

Nice add! Do you know if it's possible to set a global variable available in all github actions ? Typically the go version would be a good match for that. I tried to find something related but failed...

@aljo242
Copy link
Contributor Author

aljo242 commented Sep 21, 2022

Nice add! Do you know if it's possible to set a global variable available in all github actions ? Typically the go version would be a good match for that. I tried to find something related but failed...

Hmmmmm I haven't found a way to do that either - would be super nice though

@aljo242 aljo242 merged commit 6995021 into develop Sep 21, 2022
@aljo242 aljo242 deleted the chore/tooling-update branch September 21, 2022 15:56
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
chore: tooling updates (ignite#2847)
a52cc5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@tbruyelle tbruyelle tbruyelle approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
skip-changelog Don't check changelog for new entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljo242 @tbruyelle @lumtis