Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): seal the capability keeper #2837

Merged
merged 4 commits into from
Sep 20, 2022
Merged

fix(template): seal the capability keeper #2837

merged 4 commits into from
Sep 20, 2022

Conversation

fadeev
Copy link
Contributor

@fadeev fadeev commented Sep 17, 2022

After the keeper is created, it can be used to create scoped sub-keepers which are passed to other modules that can create, authenticate, and claim capabilities. After all the necessary scoped keepers are created and the state is loaded, the main capability keeper must be sealed to prevent further scoped keepers from being created.

Source: docs

closes #1921

tbruyelle
tbruyelle previously approved these changes Sep 17, 2022
View reviewed changes
jeronimoalbi
jeronimoalbi previously approved these changes Sep 19, 2022
View reviewed changes
@aljo242
Copy link
Contributor

aljo242 commented Sep 19, 2022

Looks like we have a test failing with error: panic: cannot scope to module via a sealed capability keeper.

@jeronimoalbi
fix: move capability keeper seal call after keeper definition paceholder
7a1b0d1 
Seal must me called after the keeper definitions because custom ones
might use scoping.
@jeronimoalbi jeronimoalbi dismissed stale reviews from tbruyelle and themself via 7a1b0d1 September 20, 2022 10:34
@aljo242 aljo242 merged commit e6c6cee into develop Sep 20, 2022
@aljo242 aljo242 deleted the fix/seal branch September 20, 2022 16:24
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@fadeev @jeronimoalbi
fix(template): seal the capability keeper (ignite#2837)
7a3c048 
* fix: seal the capability keeper

* docs: changelog

* fix: move capability keeper seal call after keeper definition paceholder

Seal must me called after the keeper definitions because custom ones
might use scoping.

Co-authored-by: jeronimoalbi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@tbruyelle tbruyelle tbruyelle approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@lumtis lumtis Awaiting requested review from lumtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capability Keeper Seal
4 participants
@fadeev @aljo242 @tbruyelle @jeronimoalbi