Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): remove handler.go #2771

Merged
merged 5 commits into from
Aug 25, 2022
Merged

feat(templates): remove handler.go #2771

merged 5 commits into from
Aug 25, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Aug 22, 2022

Closes #2764.

Removes handler.go from the module template and removes associated update logic.

Also removes old references to this file in documentation.

@aljo242 aljo242 self-assigned this Aug 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022

Visit the preview URL for this PR (updated for commit 1a1d6d4):

https://ignite-go-docs--pr2771-feat-remove-handler-t5yit0w3.web.app

(expires Wed, 31 Aug 2022 18:33:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@aljo242 aljo242 marked this pull request as ready for review August 22, 2022 18:33
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice cleaning!

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested scaffolding commands

@ilgooz ilgooz merged commit da12e5a into develop Aug 25, 2022
@ilgooz ilgooz deleted the feat/remove-handler branch August 25, 2022 14:12
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* remove and modify

* remove modify functions

* update changelog

Co-authored-by: Lucas Btd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove handler.go from the default template
4 participants