fix(cosmosaccount): return errors from sdk crypto functions
#2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 18, 2022 10:23
aljo242
requested review from
ilgooz,
lumtis,
jeronimoalbi,
tbruyelle and
fadeev
as code owners
jeronimoalbi
previously approved these changes
Aug 19, 2022
|
@aljo242 I believe the Blog Client Tutorial should be updated too. |
fixed |
|
Visit the preview URL for this PR (updated for commit baeaf99): https://ignite-go-docs--pr2760-fix-account-errors-e83az2lg.web.app (expires Wed, 31 Aug 2022 18:33:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
jeronimoalbi
approved these changes
Aug 20, 2022
jeronimoalbi
previously approved these changes
Aug 22, 2022
tbruyelle
previously approved these changes
Aug 22, 2022
jeronimoalbi
previously approved these changes
Aug 22, 2022
|
@tbruyelle maybe this could help with the issue in node cmd? |
jeronimoalbi
previously approved these changes
Aug 23, 2022
how could it be ?
|
tbruyelle
previously approved these changes
Aug 23, 2022
|
Just added a changelog entry :) Apologies for re-requesting reviews so much ! |
tbruyelle
approved these changes
Aug 23, 2022
jeronimoalbi
approved these changes
Aug 23, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…#2760) * return errors * make corresponding changes * format * fix doc * fix merge conflicts * actually fix merge * revert * format: * add changelog Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: İlker G. Öztürk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading cosmos SDK to
v0.46.0changed the signatures of functions inkeyringused bycosmosaccountlikeAddress()andGetPubKey()to return errors.This PR modifies our wrapper functions to also return errors and makes the corresponding changes in the codebase.
Closes #2679