Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): update notes for v0.24.0 #2757

Merged
merged 15 commits into from
Sep 6, 2022
Merged

Conversation

jeronimoalbi
Copy link
Member

@jeronimoalbi jeronimoalbi commented Aug 18, 2022

Related to #2756

@jeronimoalbi jeronimoalbi self-assigned this Aug 18, 2022
@fadeev fadeev mentioned this pull request Aug 18, 2022
aljo242
aljo242 previously approved these changes Aug 18, 2022
@ilgooz
Copy link
Member

ilgooz commented Aug 18, 2022

Can we make sure we have the logs from #2694 in here, before merging this PR? 🙏

aljo242
aljo242 previously approved these changes Aug 19, 2022
tbruyelle
tbruyelle previously approved these changes Aug 22, 2022
@ilgooz
Copy link
Member

ilgooz commented Aug 22, 2022

@tbruyelle should we add the notes node cmd as well? If so can you please create a PR to be merged into this one or directly add a commit?

@tbruyelle tbruyelle dismissed stale reviews from aljo242 and themself via a3f541f August 22, 2022 11:00
@tbruyelle
Copy link
Contributor

@ilgooz node commands feature added to the CL

changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
@ilgooz ilgooz requested review from aljo242, ilgooz and fadeev August 22, 2022 11:47
tbruyelle
tbruyelle previously approved these changes Aug 22, 2022
@tbruyelle
Copy link
Contributor

tbruyelle commented Aug 22, 2022

I think it would be nice if we update the unreleased section for each PR.

This would limit the change of this kind of PR to the minimum (changing unreleased to vX.Y.Z), and since the entries would be written by the author of the change, they would probably be more complete.

We could use this CL enforcer github action to ensure that.

@tbruyelle
Copy link
Contributor

tbruyelle commented Aug 25, 2022

With CL enforcer merged in develop, all future PRs should have a CL entry, so I vote for merging this to avoid conflicts.

@aljo242
Copy link
Contributor

aljo242 commented Aug 31, 2022

Can we go ahead and merge this?

@aljo242 aljo242 merged commit 2e0147b into develop Sep 6, 2022
@aljo242 aljo242 deleted the chore/update-changelog branch September 6, 2022 12:20
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* chore: update changelog

* fix: update change log for better redability

* chore: add more details to changelog entries

Co-authored-by: Denis Fadeev <[email protected]>

* docs: add node command features

* Update changelog.md

* Update changelog.md

* Update changelog.md

Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Denis Fadeev <[email protected]>
Co-authored-by: Thomas Bruyelle <[email protected]>
Co-authored-by: İlker G. Öztürk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants