Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): remove monitoringp module from template #2648

Merged
merged 1 commit into from
Jul 25, 2022
Merged

refactor(app): remove monitoringp module from template #2648

merged 1 commit into from
Jul 25, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jul 22, 2022

Closes #2641

tbruyelle
tbruyelle approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@tbruyelle tbruyelle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that I had to delete my .ignite/ignite_cache.db or else I was still seeing some monitoringp paths in the openapi docs. But I assume this is fine.

@ilgooz ilgooz merged commit 8d8a9e1 into develop Jul 25, 2022
@ilgooz ilgooz deleted the refactor/remove-monitoringp-from-template branch July 25, 2022 11:36
@fadeev fadeev mentioned this pull request Aug 4, 2022
Closed
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
refactor(templates/app): remove monitoringp module from template (i…
a64882a 
…gnite#2648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@lumtis lumtis Awaiting requested review from lumtis

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newly scaffolded chains should not import monitoringp module by default
3 participants
@aljo242 @tbruyelle @ilgooz